chore: remove sim-time timestamp workaround #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ros2_medkit fault_manager now uses wall clock time for fault timestamps, so the UI workaround for simulation time is no longer needed.
There was a problem hiding this comment.
Pull request overview
This PR removes a workaround in the fault timestamp handling that was needed when ros2_medkit's fault_manager used simulation time instead of wall clock time. The gateway now provides proper Unix timestamps, eliminating the need for client-side detection and correction.
Changes:
- Simplified
transformFaultmethod by removing conditional timestamp logic that checked for simulation time (values < year 2000)
bburda
approved these changes
Feb 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
The ros2_medkit fault_manager now uses wall clock time for fault timestamps, so the UI workaround for simulation time is no longer needed.
Issue
Link the related issue (required):
Type
Testing
How was this tested / how should reviewers verify it?
Checklist
npm run lint)npm run build)