fix(demos): build new gateway bridge packages from source#66
Merged
Conversation
ros2_medkit_gateway now exec_depends on ros2_medkit_log_bridge and ros2_medkit_action_status_bridge. These are not in the jazzy apt repo, so the demo builds failed at rosdep install with "Unable to locate package ros-jazzy-ros2-medkit-action-status-bridge". Add both packages to the clone/mv list in the four demo Dockerfiles (turtlebot3, sensor_diagnostics, multi_ecu_aggregation, moveit) so they build from the cloned source like the other gateway packages. Verified by building the sensor_diagnostics image against gateway main: rosdep resolves, both bridges and the gateway compile, image completes.
There was a problem hiding this comment.
Pull request overview
Updates the demo container build steps so ros2_medkit_gateway’s newly declared runtime dependencies (ros2_medkit_log_bridge, ros2_medkit_action_status_bridge) are built from the cloned ros2_medkit source rather than (failing) apt/rosdep resolution for Jazzy.
Changes:
- Add
ros2_medkit_log_bridgeandros2_medkit_action_status_bridgeto the subset ofros2_medkitpackages moved into each demo’s colcon workspace. - Apply the same source-build fix across all affected demo Dockerfiles (turtlebot3, sensor_diagnostics, multi_ecu_aggregation, moveit_pick_place).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| demos/turtlebot3_integration/Dockerfile | Moves the two new bridge packages into the workspace so rosdep doesn’t try (and fail) to install them from apt. |
| demos/sensor_diagnostics/Dockerfile | Same source-build inclusion of the two bridge packages for the sensor diagnostics demo image. |
| demos/multi_ecu_aggregation/Dockerfile | Same source-build inclusion of the two bridge packages for the multi-ECU aggregation demo image. |
| demos/moveit_pick_place/Dockerfile | Extends the multi-source mv package list to include both bridge packages for the MoveIt demo image. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mfaferek93
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ros2_medkit_gatewaynow declares two runtime dependencies,ros2_medkit_log_bridgeandros2_medkit_action_status_bridge. The demo Dockerfiles clone ros2_medkit and move a fixed subset of packages into the colcon workspace; these two were not in the subset, so rosdep tried to install them from apt and failed:They are not in the jazzy apt repo, so all demo build jobs failed (turtlebot3, sensor_diagnostics, multi_ecu_aggregation; moveit on a clean build).
This adds both packages to the clone/mv list in the four demo Dockerfiles so they build from the cloned source like the other gateway packages.
Related Issue
closes #68
Checklist