Provide additional information when wallet descriptor import fails#584
Closed
3rdIteration wants to merge 2 commits intoselfcustody:mainfrom
Closed
Provide additional information when wallet descriptor import fails#5843rdIteration wants to merge 2 commits intoselfcustody:mainfrom
3rdIteration wants to merge 2 commits intoselfcustody:mainfrom
Conversation
Member
Member
Member
|
This is not required anymore, as now wallet attributes are set automatically at descriptor loading. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What is this PR for?
Provide additional information when wallet descriptor import fails
Initial work in progress and proof of concept, will test on hardware with some existing test wallets and see if additional refinements are required. (And share some examples with screenshots)
Changes made to:
Did you build the code and tested on device?
What is the purpose of this pull request?