prototype for decoupling execution from tendermint loop #2581
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2581 +/- ##
==========================================
- Coverage 43.25% 43.25% -0.01%
==========================================
Files 1447 1447
Lines 115125 115123 -2
==========================================
- Hits 49799 49797 -2
Misses 61002 61002
Partials 4324 4324
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| func (blockExec *BlockExecutor) handleFinalizeRequest(ctx context.Context, req *abci.RequestFinalizeBlock) error { | ||
| start := time.Now() |
Check warning
Code scanning / CodeQL
Calling the system time Warning
| } | ||
| // TODO: persist the corresponding ResponseCommit so we can reuse retain height after restarts. | ||
|
|
||
| saveBlockResponseTime := time.Now() |
Check warning
Code scanning / CodeQL
Calling the system time Warning
| blockExec.mempool.Lock() | ||
| defer blockExec.mempool.Unlock() | ||
|
|
||
| start := time.Now() |
Check warning
Code scanning / CodeQL
Calling the system time Warning
|
We truly appreciate your contribution and the time you’ve invested in this PR. |
|
This PR is being closed due to inactivity, but we want to acknowledge and thank you for the effort you’ve put in. |
Describe your changes and provide context
Testing performed to validate your change