Conversation
|
add a description |
|
@akash-gautam07 this needs tests ;-) |
|
@silesky updated the tests :) |
saiprasannasastry
force-pushed
the
encrypt_prop
branch
from
00d667d to
a9e3dfa
Compare
silesky
left a comment
silesky
left a comment
There was a problem hiding this comment.
Looks good, just some small changes =S
was the interface the only comment? i'd like an approval if there are no more comments because of timezone difference, but there is an issue in code, with seed being passed i am not getting a stable cipher text. |
package.json
Outdated
| }, | ||
| "devDependencies": { | ||
| "@types/jest": "^27.4.0", | ||
| "@types/node": "^16.18.40", |
There was a problem hiding this comment.
Do we actually need node types here? It's better to not have any node types in an isomorphic package, since it ensures we don't accidentally use node built-ins in our code (I sometimes add them for tests, but not ideal).
saiprasannasastry
force-pushed
the
encrypt_prop
branch
from
9558e85 to
75d228c
Compare
|
@akash-gautam07 there's an assertion that's failed . we are not getting stable identifiers can you fix this |
| const labelBytes = forge.util.encodeUtf8(label) | ||
| let ciphertextBase64: string | ||
|
|
||
| if (seed) { |
@saiprasannasastry Isn't it the purpose of utilizing RSA-OAEP is to ensure the generation of new ciphertexts each time? The tsub code also generates different encrypted ciphers each time. |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
5 participants
This PR creates a encrypt_properties case in the tsub-js, to provide functionality for encrypting the properties.