feat(core): Add zero-copy as_bytes to ScriptPubkeyExt#190
Open
alexanderwiederin wants to merge 1 commit into
Open
feat(core): Add zero-copy as_bytes to ScriptPubkeyExt#190alexanderwiederin wants to merge 1 commit into
alexanderwiederin wants to merge 1 commit into
Conversation
to_bytes allocates a Vec<u8> on every call. as_bytes returns a slice directly into kernel-managed memory by capturing the pointer handed to the writer callback, which btck_script_pubkey_to_bytes invokes synchronously before returning.
alexanderwiederin
force-pushed
the
as-bytes
branch
from
218bdf7 to
9001935
Compare
|
LGTM. For the use case of silent payments this would save a vector allocation for each output script that is not a P2TR output, very useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #20
Changes
Adds a zero-copy
as_bytesmethod toScriptPubkeyExtthat returns a slice directly into kernel-managed memory valid for the lifetime of the script object.Motivation
to_bytesallocates aVec<u8>on every call. For callers that only need to inspect or pass along the raw bytes without owning them,as_bytesavoids that allocation.Why this is not applied to other types
Scripts are opaque byte sequences -
as_bytesis the complete and useful representation. Types likeBlockandTransactionhave internal structure that callers need to deserialise to use meaningfully.