Skip to content

Conversation

@AdoX13
Copy link
Member

@AdoX13 AdoX13 commented Jul 8, 2024

Prerequisite Checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Updated relevant documentation (if needed).

Description of changes

Signed-off-by: Adelin Popa <popaadelin22@gmail.com>
@AdoX13 AdoX13 added area/reading Update to reading content area/media Update to media content area/drills Update to drills content kind/new New content / item needs-rendering The PR makes changes to the website that need to be rendered area/guides Update to guides content topic/data Related to the "Data" chapter labels Jul 8, 2024
@AdoX13 AdoX13 requested review from mariasfiraiala and teodutu July 8, 2024 13:18
@github-actions
Copy link

github-actions bot commented Jul 8, 2024

Copy link
Member

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content overall is good. Fix the issues I pointed out and the failing CI/CD tests as well: https://github.com/security-summer-school/essentials-security/pull/13/checks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convert this file to linux line endings.

Comment on lines +3 to +4
My friend Tommy is really passionate about art. Lately, he got into something called ASCII art and e-mailed me the following attachment.
I am too afraid to tell him that I don't know how to open it. Can you help?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
My friend Tommy is really passionate about art. Lately, he got into something called ASCII art and e-mailed me the following attachment.
I am too afraid to tell him that I don't know how to open it. Can you help?
My friend Tommy is really passionate about art.
Lately, he got into something called ASCII art and e-mailed me the following attachment.
I am too afraid to tell him that I don't know how to open it.
Can you help?

Use one sentence per line.

Comment on lines +3 to +4
Thanos had 6 Infinity Stones, but I have something better: 6 Infinity Hashes, that store the truth of the whole universe.
Wrap it with `SSS{}` and `_` instead of space, and spread it with everyone!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Thanos had 6 Infinity Stones, but I have something better: 6 Infinity Hashes, that store the truth of the whole universe.
Wrap it with `SSS{}` and `_` instead of space, and spread it with everyone!
Thanos had 6 Infinity Stones, but I have something better: 6 Infinity Hashes, that store the truth of the whole universe.
Wrap it with `SSS{}`, use `_` instead of space, and spread it with everyone!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly there was no need for this image to be .svg, since it's a meme, not a constructed image, but it's fine

+------------------------------------> 1. File Type
```

![Unix File Permissions 2](../media/unix_file_permissions2.svg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

@github-actions github-actions bot added the area/infra Update to infrastructure label Jul 9, 2024
@AdoX13 AdoX13 added needs-rendering The PR makes changes to the website that need to be rendered and removed needs-rendering The PR makes changes to the website that need to be rendered labels Jul 8, 2025
@github-actions
Copy link

github-actions bot commented Jul 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/drills Update to drills content area/guides Update to guides content area/infra Update to infrastructure area/media Update to media content area/reading Update to reading content kind/new New content / item needs-rendering The PR makes changes to the website that need to be rendered topic/data Related to the "Data" chapter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants