Skip to content

feat: Modify timeout parameters and local file path reading methods #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Surfacebuaa wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Modify timeout parameters and local file path reading methods #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0472209
feat: support reading local file path from environment variable
Aug 26, 2024
2037114
feat: add timeout parameters
Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 21 additions & 16 deletions ic_impl/util.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,17 +45,19 @@ void StartTransport() {
} // namespace

std::shared_ptr<yacl::link::Context> CreateLinkContextForBlackBox() {
yacl::link::ContextDesc desc;
desc.brpc_channel_protocol = "http";
size_t self_rank;
yacl::link::FactoryBrpcBlackBox::GetPartyNodeInfoFromEnv(desc.parties,
self_rank);

if (util::GetParamEnv("start_transport", false)) {
StartTransport();
}
yacl::link::ContextDesc desc;
desc.brpc_channel_protocol = "http";
size_t self_rank;
yacl::link::FactoryBrpcBlackBox::GetPartyNodeInfoFromEnv(desc.parties, self_rank);
desc.connect_retry_times = util::GetParamEnv("connect_retry_times", 3600);
desc.connect_retry_interval_ms = util::GetParamEnv("connect_retry_interval_ms", 5000);
desc.recv_timeout_ms = util::GetParamEnv("recv_timeout_ms", 3600000);

if (util::GetParamEnv("start_transport", false)) {
StartTransport();
}

return yacl::link::FactoryBrpcBlackBox().CreateContext(desc, self_rank);
return yacl::link::FactoryBrpcBlackBox().CreateContext(desc, self_rank);
}

std::shared_ptr<yacl::link::Context> CreateLinkContextForWhiteBox(
Expand Down Expand Up @@ -142,14 +144,17 @@ char* GetParamEnv(std::string_view env_name) {
namespace {

std::optional<std::string> GetIoFileNameFromEnv(bool input) {
char* host_url = std::getenv("system.storage");
if (!host_url || !absl::StartsWith(host_url, "file://")) {
host_url = std::getenv("system.storage.host.url");
char* host_url = std::getenv("system.storage");
if (!host_url || !absl::StartsWith(host_url, "file://")) {
return std::nullopt;
host_url = std::getenv("system.storage.host.url");
if (!host_url) {
host_url = std::getenv("system.storage.localfile");
}
if (!host_url || !absl::StartsWith(host_url, "file://")) {
return std::nullopt;
}
}
}
std::string_view root_path = host_url + 6;
std::string_view root_path = host_url + 6;

char* json_str = nullptr;
if (input) {
Expand Down