Fix deprecation warnings and add aarch64 build support#38
Conversation
- Remove usage of deprecated realtime_ws module from main.rs - Add #![allow(deprecated)] to realtime_ws.rs for internal usage - Add RUSTFLAGS with fp16 target feature for aarch64 builds in CI - Update README with aarch64 build instructions Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
CodeProt AI is analyzing the changes... ⏳ |
🤖 CodeProt AI - Free Version PR SummaryOverview Technical Summary
Issues Found
🆓 You are using CodeProt AI Free VersionFree Version Features:
Upgrade to Premium Version for:
🌟 Upgrade to Premium Version NowVisit https://codeprot.com/pricing to learn more about features and pricing details. CodeProt AI - Making Code Review Smarter, Making Development More Efficient |
There was a problem hiding this comment.
Pull request overview
This PR addresses deprecation warnings by removing usage of the deprecated realtime_ws module from the main codebase while maintaining backward compatibility internally, and adds necessary build configuration for aarch64 architecture support.
Changes:
- Removed
realtime_wsmodule usage frommain.rsto eliminate deprecation warnings - Added deprecation suppression within
realtime_ws.rsfor internal compatibility - Configured aarch64 builds with
fp16target feature in CI and documentation
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/services/realtime_ws.rs | Added #![allow(deprecated)] attribute to suppress warnings within the module |
| src/main.rs | Removed imports and code related to StableRealtimeConfig and realtime WebSocket handler setup |
| README.md | Added build instructions for aarch64 with fp16 target feature flag |
| .github/workflows/release.yml | Added RUSTFLAGS environment variable for aarch64 build configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main.rs
Outdated
| tts: _, | ||
| asr: _, |
There was a problem hiding this comment.
The pattern match now ignores both tts and asr fields. Consider using .. syntax to ignore remaining fields instead of explicitly listing them with _, which would be more maintainable if additional fields are added to the struct in the future.
| tts: _, | |
| asr: _, | |
| .. |
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add .cargo/config.toml with fp16 target feature for aarch64 - Remove RUSTFLAGS from CI workflows (now handled by cargo config) - Update README to reflect the change Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Keep the /v1/realtime endpoint functional while suppressing deprecation warnings with targeted #[allow(deprecated)] attributes. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary
realtime_wsmodule frommain.rs#![allow(deprecated)]torealtime_ws.rsfor internal usageRUSTFLAGSwithfp16target feature for aarch64 builds in CITest plan
🤖 Generated with Claude Code