Conversation
Collaborator
L-jasmine
commented
Jan 19, 2026
L-jasmine
commented
- update ui
- support vowel
- update setup.html
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces vowel detection support, enhances the UI system with improved rendering and avatar animations, and adds configurable AFE (Audio Front End) parameters through setup pages.
Changes:
- Added vowel detection to audio protocol and processing pipeline
- Refactored UI system with new display abstractions and avatar support
- Added configurable AFE parameters (linear gain, AGC target level, compression gain) via Bluetooth
Reviewed changes
Copilot reviewed 18 out of 22 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ws.rs | Added vowel parameter to audio chunk events and updated WebSocket connection URLs to request vowel data |
| src/ui.rs | Major refactor introducing display abstraction traits, GIF/PNG rendering, and modular image components |
| src/protocol.rs | Extended ServerEvent enum with vowel field for audio chunks |
| src/main.rs | Refactored settings management, integrated new UI system, and updated main application flow |
| src/bt.rs | Added BLE characteristics for AFE parameter configuration |
| src/boards/mod.rs | Implemented default UI components including ChatUI and ConfiguresUI |
| src/boards/cube2.rs | Removed hardcoded AFE configuration values |
| src/boards/cube.rs | Removed hardcoded AFE configuration values |
| src/boards/base.rs | Removed hardcoded AFE configuration values |
| src/boards/atom_box.rs | Implemented custom UI with chunked rendering for performance optimization |
| src/audio.rs | Added vowel event handling and made AFE parameters configurable via global statics |
| src/app.rs | Integrated vowel events for avatar animation and updated UI rendering throughout event handling |
| setup/index_zh.html | Added advanced settings panel for AFE parameter configuration (Chinese) |
| setup/index.html | Added advanced settings panel for AFE parameter configuration (English) |
| sdkconfig.defaults | Commented out BT_NIMBLE_HOST_TASK_STACK_SIZE configuration |
| components/hal_driver/lcd.h | Exposed lcd_dma_buffer for direct access |
| components/hal_driver/lcd.c | Optimized DMA buffer allocation and LCD configuration |
| Cargo.toml | Updated version to 0.3.0, replaced tinygif with image crate, added custom_ui feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.