ROCK-8404 Removed custom email from group manager#213
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the ability for Group Manager users to choose a custom “From Email” when sending roster emails, standardizing outbound email to use the block-configured safe sender address.
Changes:
- Removed the “From Email” dropdown and related configuration (restricted domain blacklist + help text).
- Displayed the configured safe sender address as a read-only “From Email” value in the email UI.
- Forced
Communication.FromEmailto the configured safe sender value when sending.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Plugins/org.secc.GroupManager/org_secc/GroupManager/LWYARoster.ascx.cs | Removes dynamic From-address selection logic and always sends from SafeSenderEmail. |
| Plugins/org.secc.GroupManager/org_secc/GroupManager/LWYARoster.ascx | Replaces selectable “From Email” dropdown with a read-only literal display. |
….ascx.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/secc/RockPlugins/sessions/922a0f5c-d114-4800-b5da-146765e1c987 Co-authored-by: stphnlee <902855+stphnlee@users.noreply.github.com>
gmcgrady
approved these changes
Apr 13, 2026
Contributor
gmcgrady
left a comment
gmcgrady
left a comment
There was a problem hiding this comment.
Taking the time to re-factor from a drop down list to a text attribute in lieu of setting the drop down & making it uneditable was a good choice--it's cleaner. Also, copilot made a good catch on requiring the safe sender email to avoid failed deliveries. Approving and merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.