Bug fix for international character support #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Not sure why the test failed for node v0.12. I tried it locally for that version and it worked fine. Is there a way to retest? |
Author
|
Added a new issue to support the PR: #47 |
Contributor
|
@hpalz + 1 I think it should be merged |
|
@hpalz Hi, Thanks a lot for your fix. I personally need a fixed version of NPM (using this library from TypeScript code seems that is the only adequate way without typing the whole code.) So, I forked and published a fixed version to npm. https://www.npmjs.com/package/json-socket-international Regards. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue with this library when parsing multiple messages with international characters. Since the messages are encoded using Buffer.byteLength, the substring in handleData fails (since byteLength will be greater than the actual substring length):
https://github.com/sebastianseilund/node-json-socket/blob/master/lib/json-socket.js#L106
I am pushing 3 commits to demonstrate the issue and support the bug fix proposal.
Please let me know if you have any questions or concerns! 🍻