Conversation
| collideHandler(object1, object2, collideCallback, processCallback, callbackContext, overlapOnly) { | ||
| // Only collide valid objects | ||
| if (!object2 && object1.type === Phaser.GROUP) { | ||
| if (object1.type instanceof Phaser.GameObjects.Group && !object2) { |
There was a problem hiding this comment.
object1.type instanceof Phaser.GameObjects.Group && !object2
This should be
object1 instanceof Phaser.GameObjects.Group && !object2
same with ln 751
| } | ||
| // GROUPS | ||
| else if (object1.type === Phaser.GROUP) { | ||
| else if (object1.type instanceof Phaser.GameObjects.Group) { |
There was a problem hiding this comment.
object1.type instanceof Phaser.GameObjects.Group
should be
object1 instanceof Phaser.GameObjects.Group
BrennanTanner
left a comment
BrennanTanner
left a comment
There was a problem hiding this comment.
remove .type from object on line 736 & line 751
Those probably worked in the past. I think I'll officially take on the maintenance of this plugin. There are many features that's been broken by updates. Plus I'll also fix it to work with Phaser's new features. It'll take a while but I think when I'm ready I'll put a comment here leading to my repo so people know to use that instead of this. |
2 participants
I'm sorry if this is coming lat, but this a fix I made about 2 years back.