Split compiler flags by whitespace. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously setup.py splits compiler flags by a single whitespace, which causes build failures when there are two space characters causing an extra empty string being added to the compiler command line.
kxxt
added a commit
to kxxt/archriscv-packages
that referenced
this pull request
May 3, 2023
See the [upstreamed PR](sebasguts/JuPyMake#5) for more context.
kxxt
added a commit
to kxxt/archriscv-packages
that referenced
this pull request
May 3, 2023
See the [upstreamed PR](sebasguts/JuPyMake#5) for more context.
felixonmars
pushed a commit
to felixonmars/archriscv-packages
that referenced
this pull request
May 3, 2023
See the [upstreamed PR](sebasguts/JuPyMake#5) for more context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously setup.py splits compiler flags by a single whitespace, which causes build failures when there are two space characters, causing an extra empty string being added to the compiler command line.
In my case,
polymake-config --cflagsreturned a string with two space characters before the last compiler flag:An extra empty string got passed to the compiler and it caused a cryptic error.