Additional ceph disks for clusters#84
Open
dahoat-sprecher wants to merge 3 commits intoseapath:mainfrom
Open
Conversation
Modifications so that also cluster setups support multiple disks per VM. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Daniel Hofer <daniel.hofer@sprecher-automation.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Daniel Hofer <daniel.hofer@sprecher-automation.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Daniel Hofer <daniel.hofer@sprecher-automation.com>
|
eroussy
requested changes
Mar 10, 2026
Member
eroussy
left a comment
eroussy
left a comment
There was a problem hiding this comment.
Thanks for the PR, it is a complicated one and it will have to be tested properly.
I have made some comments here and on the ansible PR. I will have another SEAPATH maintainer have a look also
| </disk> | ||
| """.format( | ||
| rbd_secret, POOL_NAME, ceph_image, hosts_list, | ||
| dev, target_disk_bus |
Member
There was a problem hiding this comment.
I don't think it is relevant to pass the dev variable here. You can just iterate over the number of disk in python and increment the letter (vdb, vdc ...)
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
| """ |
Member
There was a problem hiding this comment.
Can you squash your first two commits together ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello to All,
As we noticed, the guest.xml.j2 contained partial support for (one) additional disk(s) for VMs. This Pull Request adds this feature also to clusters for an arbitrary amount of disks. However, this contains also a breaking change as the inventory for a VM uses a map instead of a list:
However, this permits explicitly naming additional disks.
See also: seapath/ansible#893
Best regards,
Daniel