Repository navigation
Keep the firmware DSDT to avoid stale GNVS addresses - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After an EC reset on H7607BA.300, the firmware moved GNVS from 0x86f50000 to 0x86f70000. The copied DSDT still used the old address. ACPI exposed only six of twenty CPU devices, and CPUFreq could not initialize. The retained original and current firmware DSDTs differ only in that address byte and the checksum.
Keep the native DSDT on each boot. The existing
acpi_osi="!Windows 2022"option already supplies the SSPM behavior that the DSDT patch provided. Remove the DSDT builder, input/output pins, archive member, installation and package payload. Keep the pinned ASUS SSDT transformation. Verify that the early ACPI archive contains only that SSDT, including when an extra table uses a different filename extension. Preserve the legacy DSDT checkpoint path for rollback compatibility.Validation:
PYTHONOPTIMIZE=1mode. The new regression checks fail against 29c045b, where the duplicate-name bug was reproduced.9b28ffc14c19f8b7ea2278de88ff9ec070f5f70401107d81fef067a916aa9695.68420c5248a237b01267bf8713867f53358252d0d3935fb09c0e66b02c39153e.Runtime evidence on the corrected image (kernel 7.3.0-26, NVIDIA 620.70.06, firmware DSDT OEM revision 4, retained ASUS SSDT):
kernel/firmware/acpi/SSDT.amlat the pinned SHA-256.Token change: code -366, tests +756, docs +115 (about 4 characters a token). The test and doc growth was in the commit that both review passes accepted.
Part of #3
🤖 Generated with Claude Code