feat: balmy for quotes #556
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
chad-js
commented
Jan 15, 2026
Comment on lines
+465
to
+469
| excludeAdditionalSources: ['kyberswap'], // Kyberswap seems to give flaky quotes on Base for WETH to WEETH | ||
| }, | ||
| collateralToDebt: { | ||
| type: 'lifi', | ||
| allowBridges: 'none', | ||
| type: 'balmy', | ||
| excludeAdditionalSources: ['kyberswap'], // Kyberswap seems to give flaky quotes on Base for WEETH to WETH |
Collaborator
Author
There was a problem hiding this comment.
noticed this during integration tests and testing the ui, will often give quotes that say it will give enough but simulation fails
johnwhitton
reviewed
Jan 15, 2026
Contributor
johnwhitton
left a comment
johnwhitton
left a comment
There was a problem hiding this comment.
Tested this locally and looks good
bun test:integration:new
Test Files 2 passed (2)
Tests 10 passed (10)
Start at 13:42:09
Duration 78.03s (transform 595ms, setup 3.83s, collect 2.55s, tests 115.29s, environment 655ms, prepare 55ms)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.