Replace busy-wait spin loop with Atomics.wait() in fileLock.ts#5
Merged
seabearDEV merged 2 commits intoclaude/verify-codexcli-readme-qVZ44from Feb 21, 2026
Merged
Conversation
Co-authored-by: seabearDEV <40605056+seabearDEV@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on verify codexcli readme
Replace busy-wait spin loop with Atomics.wait() in fileLock.ts
Feb 21, 2026
seabearDEV
approved these changes
Feb 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to replace a CPU-intensive busy-wait spin loop with Atomics.wait() for better CPU efficiency during lock acquisition retries. However, the implementation has a critical flaw that prevents it from working.
Changes:
- Modified
src/utils/fileLock.tsto useAtomics.wait()with a shared buffer instead of busy-wait loop - Extensive modifications to
package-lock.jsonremoving/adding "peer": true flags on various dependencies
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/utils/fileLock.ts | Replaces busy-wait loop with Atomics.wait() for sleep during lock retry backoff |
| package-lock.json | Modifies peer dependency flags across numerous ESLint and dev packages (appears unrelated to PR purpose) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
seabearDEV
approved these changes
Feb 21, 2026
ee15132
into
claude/verify-codexcli-readme-qVZ44
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
acquireLockused a spin loop (while (Date.now() - start < waitMs)) for exponential backoff between retries, burning CPU under any lock contention.Changes
src/utils/fileLock.ts: Replace spin loop withAtomics.wait(), which suspends the thread for the target duration at the OS level with zero CPU burnSharedArrayBuffer/Int32Arrayonce at module level (_sleepBuf) rather than on every retryThe function stays synchronous — no async propagation needed — since
Atomics.wait()is a blocking call.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.