Mask plaintext value in codex_set MCP response when encryption is used#3
Merged
seabearDEV merged 3 commits intoclaude/verify-codexcli-readme-qVZ44from Feb 21, 2026
Merged
Conversation
Co-authored-by: seabearDEV <40605056+seabearDEV@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback on Claude/verify codexcli readme
Mask plaintext value in Feb 21, 2026
codex_set MCP response when encryption is used
seabearDEV
approved these changes
Feb 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a security vulnerability where the codex_set MCP tool was leaking plaintext values in success responses when encryption was enabled. The fix ensures that encrypted values are properly masked in tool responses, preventing sensitive data exposure through the MCP interface.
Changes:
- Modified
codex_settool response messages to display[encrypted]instead of the plaintext value when theencryptparameter is true
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: seabearDEV <40605056+seabearDEV@users.noreply.github.com>
seabearDEV
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
codex_setwas called withencrypt: true, the success response echoed back the plaintext value, leaking it through the MCP tool response despite the stored value being encrypted.Changes
src/mcp-server.ts: Replacevaluewith[encrypted]in bothcodex_setresponse paths (with and without alias) whenencryptis truthysrc/__tests__/mcp-server.test.ts: Added two tests to verify the masking behavior:[encrypted]is shown (and plaintext is absent) in the response whenencrypt: trueis passed without an alias🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.