Skip to content

Conversation

@R-Palazzo
Copy link
Contributor

@R-Palazzo R-Palazzo commented Feb 9, 2026

Resolve #544
CU-86b8f9y6q

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 56.00000% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.41%. Comparing base (8ca5d9b) to head (ed0a3e2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sdgym/cli/summary.py 0.00% 6 Missing ⚠️
sdgym/cli/__main__.py 0.00% 4 Missing ⚠️
sdgym/benchmark.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
+ Coverage   81.39%   81.41%   +0.01%     
==========================================
  Files          33       33              
  Lines        2817     2819       +2     
==========================================
+ Hits         2293     2295       +2     
  Misses        524      524              
Flag Coverage Δ
integration 54.45% <36.00%> (-0.04%) ⬇️
unit 75.91% <48.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@R-Palazzo R-Palazzo force-pushed the fix-upload-results-err-columns branch from eb3028f to 59133dd Compare February 9, 2026 17:45
@R-Palazzo R-Palazzo changed the base branch from main to issue-528-support-python-3.14 February 9, 2026 17:45
@R-Palazzo R-Palazzo changed the title Fix upload results err columns Internal benchmark results upload crashes if there's no error column in the result table. Feb 9, 2026
@sdv-team
Copy link
Contributor

sdv-team commented Feb 9, 2026

@R-Palazzo R-Palazzo marked this pull request as ready for review February 9, 2026 17:48
@R-Palazzo R-Palazzo requested a review from a team as a code owner February 9, 2026 17:48
@R-Palazzo R-Palazzo requested review from amontanez24, pvk-developer and sarahmish and removed request for a team and sarahmish February 9, 2026 17:48
@R-Palazzo R-Palazzo self-assigned this Feb 9, 2026
@R-Palazzo R-Palazzo changed the title Internal benchmark results upload crashes if there's no error column in the result table. Internal benchmark results upload crashes if there's no error column in the result table Feb 9, 2026
Base automatically changed from issue-528-support-python-3.14 to main February 10, 2026 17:32
@R-Palazzo R-Palazzo force-pushed the fix-upload-results-err-columns branch from 674739f to ed0a3e2 Compare February 11, 2026 14:20
@R-Palazzo R-Palazzo merged commit aee02c1 into main Feb 11, 2026
51 checks passed
@R-Palazzo R-Palazzo deleted the fix-upload-results-err-columns branch February 11, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Internal benchmark results upload crashes if there's no error column in the result table

4 participants