#41 fixing effectless --preview-text parameter for file output#42
Open
myselfhimself wants to merge 1 commit intosdushantha:masterfrom
Open
#41 fixing effectless --preview-text parameter for file output#42myselfhimself wants to merge 1 commit intosdushantha:masterfrom
myselfhimself wants to merge 1 commit intosdushantha:masterfrom
Conversation
Owner
|
Good catch! I did not notice this. |
Author
|
Hello
the code did not have to be moved into a function, but I moved it into a
function to make it "cleaner".
The fix consists in running the multiple variables fallback lines not just
at main() time, but before the 2 preview commands code which get run before
the main() itself.
So I moved this variables fallback chunk outside of the main to be before
the 2 preview commands and main itself, so it serves 3 cases instead of
just 1.
Have a nice day
st 24. 6. 2020 v 12:22 odesílatel Siddharth Dushantha <
notifications@github.com> napsal:
… Good catch! I did not notice this.
Could you explain how your changes fixes this? From looking at your
changes, all you did was move some code into a function
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#42 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJU5QX2GKFQUCKHHOYVJG3RYHHX7ANCNFSM4OGEN7KQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing #41 fully