Skip to content

Conversation

@M0Rf30
Copy link

@M0Rf30 M0Rf30 commented Jan 6, 2026

Summary

This PR adds support for the Novatek NT36672A e7t touchscreen variant found on the Xiaomi Redmi Note 6 Pro (tulip).

Changes

  • Add new chip data structure for NT36672A e7t variant with correct wake_type (0x02)
  • Add device tree binding for novatek,nt36672a-e7t-ts
  • Register variant in both OF and I2C device ID tables

@minlexx
Copy link
Member

minlexx commented Jan 6, 2026

I think devicetree bindings change should be a separate commit from driver change, because that's what upstream requires. Other than that I see no issues

M0Rf30 added 2 commits January 6, 2026 18:45
Add compatible string for the Novatek NT36672A e7t touchscreen variant
found on the Xiaomi Redmi Note 6 Pro (tulip).

This variant uses different chip parameters compared to the standard
NT36672A, specifically a different wake_type value.

Signed-off-by: Gianluca Boiano <morf3089@gmail.com>
Add support for the Novatek NT36672A touchscreen variant found on the
Xiaomi Redmi Note 6 Pro (tulip) which uses a different wake_type value
(0x02 instead of 0x01).

The touchscreen was failing to initialize with error -5 due to the
wake_type parameter mismatch during probe. This adds a new chip data
structure for the e7t variant with the correct wake_type value.

Fixes: sdm660-mainline#155

Signed-off-by: Gianluca Boiano <morf3089@gmail.com>
@M0Rf30 M0Rf30 force-pushed the qcom-sdm660-6.18.y-tulip-touch branch from 81ed9f2 to 39f4ca8 Compare January 6, 2026 17:46
Copy link
Member

@minlexx minlexx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, if this works then all good

@M0Rf30 M0Rf30 merged commit 8b10139 into sdm660-mainline:qcom-sdm660-6.18.y Jan 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants