Add Acurite Sensors and make it easier to add additional sensors#4
Draft
PlasmaEye wants to merge 76 commits intosdague:mainfrom
Draft
Add Acurite Sensors and make it easier to add additional sensors#4PlasmaEye wants to merge 76 commits intosdague:mainfrom
PlasmaEye wants to merge 76 commits intosdague:mainfrom
Conversation
json.load takes in a string
This reverts commit cf00c8d.
since i created a specific class for it
have sensor type specific json
will need to be cleaned up
This reverts commit cf00c8d.
since i created a specific class for it
have sensor type specific json
will need to be cleaned up
PlasmaEye
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm hoping this will make it easier to add additional sensors in the future. I'm looking for feedback on this approach. This does have the assumption that the input is JSON.
This change is