Fix empty leaderboard state after resetting filters#71
Open
kevinfosterNG wants to merge 1 commit into
Open
Conversation
|
@kevinfosterNG is attempting to deploy a commit to the sculpt Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The homepage can fall into an empty-table state after users switch away from the default leaderboard view and then reset back to it.
Root cause
The default view was treated as "seeded" any time the filter state returned to the original cost/no-filter combination, even after hydration. Once the filter-reset effect cleared the current rows, the board skipped fetching because it incorrectly assumed the server-seeded rows were still active.
Impact
Returning to the default homepage leaderboard view now restores rows correctly instead of showing an empty table.
Validation
pnpm buildpnpm exec tsc --noEmitFails in the current repo due to pre-existing type/config issues unrelated to this change.
pnpm lintFails in the current repo because the script still uses
next lint, which is invalid under the current Next.js setup.pnpm testFails in the current repo because the script runs
nodedirectly ontest/ccusage.test.mts.