Adds gas_target optional fields to utilize evaporation api#75
Open
darwinzer0 wants to merge 12 commits intoscrtlabs:masterfrom
Open
Adds gas_target optional fields to utilize evaporation api#75darwinzer0 wants to merge 12 commits intoscrtlabs:masterfrom
darwinzer0 wants to merge 12 commits intoscrtlabs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds optional
gas_targetfields to all execute messages, and then uses the new evaporation api at the end of execution to burn gas up to amount sent in.It does not pass a gas target through to a callback contract in the case of the
sendfunction. If it might be useful, then I could add a newsend_with_evaporatemessage type that would work with an updated receiver interface.