Skip to content

[Fix] metered execution suspend before guest program completed#246

Merged
noel2004 merged 4 commits intomasterfrom
fix/vm_execute_guest
Mar 2, 2026
Merged

[Fix] metered execution suspend before guest program completed#246
noel2004 merged 4 commits intomasterfrom
fix/vm_execute_guest

Conversation

@noel2004
Copy link
Member

While handling unexpected large chunks, using metered execution for obtaining cycles / cost would suspend the execution at early stage so the program can not finish.

This RP handle such issue by 2 improve:

  1. Increase the preset max_cost so metered execution can handle bigger execution traces (~1500 segs for our chunk circuit)
  2. If 1 still not work, we fall back to common execution, which has no hard limit on segments / cost to ensure the program can finish. In this case, we declined tracing the cycles (But at least we have known it is quite huge).

@noel2004 noel2004 requested a review from lispc February 27, 2026 01:08
@github-actions github-actions bot added crate-prover Updates to the prover crate crate-integration Updates to the integration crate labels Feb 27, 2026
@noel2004
Copy link
Member Author

Has applied on prover and tested against several sepolia chunks, all passed.

Copy link
Collaborator

@roynalnaruto roynalnaruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add more context to the vm module? And some nitpicks.

@noel2004 noel2004 merged commit bb1a23d into master Mar 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crate-integration Updates to the integration crate crate-prover Updates to the prover crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants