Conversation
dreamATD
force-pushed
the
precompiles/fptower
branch
from
c6e04fe to
df2b45c
Compare
dreamATD
force-pushed
the
precompiles/fptower
branch
from
df2b45c to
baa4e98
Compare
dreamATD
force-pushed
the
precompiles/fptower
branch
from
36c2b48 to
3327dce
Compare
hero78119
approved these changes
Jan 4, 2026
Collaborator
hero78119
left a comment
hero78119
left a comment
There was a problem hiding this comment.
LGTM! just mark one TODO which will address in the future ❤️
| let wits = FpOpWitCols { | ||
| is_add: cb.create_witin(|| "fp_op_is_add"), | ||
| is_sub: cb.create_witin(|| "fp_op_is_sub"), | ||
| is_mul: cb.create_witin(|| "fp_op_is_mul"), |
Collaborator
There was a problem hiding this comment.
These op flags are for reused same chip for different ecall opcode but currently we still build them into different chip, so this boolean columns along with respective constraints are redundant overhead.
Its ok for now, later we tweak design to implement different opcode share same chip. Its equivalent to batch main sumcheck and I believe it will bring more performance gain in particular in GPU: less kernel invoke, less cpu/gpu execution interleaving
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add fptower precompiles.
Run the following commands to test: