Name Visibility + Create / Destroy detection#47
Open
WarperSan wants to merge 7 commits intoscriptcoded:mainfrom
Open
Name Visibility + Create / Destroy detection#47WarperSan wants to merge 7 commits intoscriptcoded:mainfrom
WarperSan wants to merge 7 commits intoscriptcoded:mainfrom
Conversation
… visibility of the name
Owner
|
Hey! Sorry, I completely missed this! I'm completely overloaded at the moment and don't have a lot of time to maintain this mod with all the breaking changes in the modding APIs... But I'll do my best to tackle this as soon as I get the time :) Sounds like great additions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Features
Name Visibility
In my testing, I've found it is quite annoying to have the name always displayed. It breaks the immersion if, for example, the loader is hidden in a structure. To solve this, I've added the rule
alwaysShowLoaderName, which determines if the custom name is always displayed or not.This rule simply overrides the
setCustomNameVisible()value, which was alwaystrue.Note: as I'm writing this, the rule doesn't change the visibility of existing loaders.
Create / Destroy detection
In my testing, I've found the mod doesn't have a way to detect when a loader is created nor destroyed. It would be impossible to reliably detect if a cart is a loader.
To fix this, the dispenser now sends vibrations depending on the action. Right now, creating a loader uses the frequency
6, and destroying a loader uses the frequency5.Note: as I'm writing this, both actions can be triggered at once (if you create and destroy with the same tick). However, Doing the same action multiple times in the same tick will only trigger the vibration once.
Note 2: I've already written the game tests. They use a new structure, but work fine.
Other
I've fixed the warnings that IntelliJ gave me when loading the project. I'm not sure if I broke anything, but I highly doubt.