-
Notifications
You must be signed in to change notification settings - Fork 100
Submodule i18n #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Submodule i18n #568
Conversation
Thank you for the pull request! 💙The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
|
hi @andrewtavis question: I observe that, unlike with Android, if there's a mismatch with the i18n keys, nothing really breaks. Do you know how to check if I've got all the keys correctly? |
|
hi @andrewtavis update: I removed reference for the old i18n folders and readded the new one and now when I built I got this error: |
|
update: turns out I don't need to add new i18n reference. I guess it works now? Still don't know how to show missing i18n keys. |
I added Localizable.xcstrings as a reference, and it resulted in this when built. I think it only now started to recognize the changes in the submodule. Do you have suggestions on what to do about this? @andrewtavis |
|
Apparently Xcode is adding |

Contributor checklist
xcodebuildandswiftlint --strictcommands as directed in the testing section of the contributing guideDescription
Related issue