Skip to content

Conversation

@catreedle
Copy link
Collaborator

Contributor checklist


Description

  • Change i18n subtree into submodule
  • Update documentation
  • Update i18n keys in iOS

Related issue

@github-actions
Copy link

Thank you for the pull request! 💙

The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and iOS rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the CI unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@catreedle
Copy link
Collaborator Author

hi @andrewtavis

question: I observe that, unlike with Android, if there's a mismatch with the i18n keys, nothing really breaks. Do you know how to check if I've got all the keys correctly?

@catreedle
Copy link
Collaborator Author

hi @andrewtavis update: I removed reference for the old i18n folders and readded the new one and now when I built I got this error:
Multiple commands produce '/some/path/Products/Debug-iphonesimulator/Scribe.app/string.xml'

@catreedle
Copy link
Collaborator Author

update: turns out I don't need to add new i18n reference. I guess it works now? Still don't know how to show missing i18n keys.

@catreedle
Copy link
Collaborator Author

Screenshot 2025-12-30 at 14 03 35

I added Localizable.xcstrings as a reference, and it resulted in this when built. I think it only now started to recognize the changes in the submodule. Do you have suggestions on what to do about this? @andrewtavis

@catreedle
Copy link
Collaborator Author

Apparently Xcode is adding
"extractionState" : "stale",
to keys not found in iOS code. So maybe there's nothing to be done about it?
It also changes language code "kan" to "kn".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant