-
Notifications
You must be signed in to change notification settings - Fork 100
Add word-for-word delete function #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit will add word-for-word delete function if you hold the delete button.
Thank you for the pull request! 💙The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
This commit will fix some lint issues
This commit will fix lint issues
|
Thanks so much for the PR here, @henrikth93! I'll try to review it in the coming days. Would you be able to send along a changelog entry for the work here with a reference to the issue? |
This commit will update the changelog to include the issue 301
done |
andrewtavis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: Is working very well, @henrikth93! The words are being deleted word by word instantly, but I think that this is good enough to close the issue, and we can adjust if there's interest later on 😊
This commit will add word-for-word delete function if you hold the delete button.
Contributor checklist
xcodebuildandswiftlint --strictcommands as directed in the testing section of the contributing guideDescription
Related issue