Fix _create-energy inserting a object with a numeric id#146
Merged
o4kapuk merged 1 commit intoscreeps:masterfrom Mar 1, 2026
Merged
Fix _create-energy inserting a object with a numeric id#146o4kapuk merged 1 commit intoscreeps:masterfrom
o4kapuk merged 1 commit intoscreeps:masterfrom
Conversation
tiennou
force-pushed
the
fix/history-id-break
branch
from
3c305c9 to
bc9d66c
Compare
CarsonBurke
pushed a commit
to screepers/steamless-client
that referenced
this pull request
Nov 3, 2025
This fixes a bug with resource piles having the server use the "bulk insert counter" as an id, which makes the `_.find()` check miss them when the "object should be removed"/`null` gets processed in the same chunk. Based on #48. Ref: screeps/engine#146
This causes issues later in the client when viewing history, as that id can never match with the for…in stringified key when unrolling the packed history chunk, leading to stray objects saying alive until the next chunk is loaded.
tiennou
force-pushed
the
fix/history-id-break
branch
from
bc9d66c to
c2c4ad9
Compare
o4kapuk
approved these changes
Mar 1, 2026
Contributor
Author
|
Nice, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This causes issues later in the client when viewing history, as that id can never match with the for…in stringified key when unrolling the packed history chunk, leading to stray objects saying alive until the next chunk is loaded.