Strip PNG metadata to fix Screenshotbot false positives#46
Open
EmilioBejasa wants to merge 4 commits intomainfrom
Open
Strip PNG metadata to fix Screenshotbot false positives#46EmilioBejasa wants to merge 4 commits intomainfrom
EmilioBejasa wants to merge 4 commits intomainfrom
Conversation
Re-encode screenshots after tests complete to remove EXIF timestamps that cause Screenshotbot to flag identical images as changed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Strip metadata chunks (tIME, tEXt, iTXt, etc.) directly from PNG files at the byte level. This preserves the exact pixel data bytes unlike Bitmap.compress which may produce non-deterministic output. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The on-device approach in BaseScreenshotTestRunner didn't work because the Gradle plugin pulls screenshots from a different path. Instead, hook into recordDebugAndroidTestScreenshotTest with a doLast block that re-encodes PNGs via javax.imageio on the CI host after they've been pulled from the emulator but before Screenshotbot uploads them. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BitmapFactory/Bitmap.compress()to decode and re-encode PNGs without metadataBaseScreenshotTestRunner.finish()beforeScreenshotRunner.onDestroy()Test plan
screenshot-testsjob passes🤖 Generated with Claude Code