Register StoryRenderer component with AppRegistry#33
Open
EmilioBejasa wants to merge 7 commits intomainfrom
Open
Register StoryRenderer component with AppRegistry#33EmilioBejasa wants to merge 7 commits intomainfrom
EmilioBejasa wants to merge 7 commits intomainfrom
Conversation
BaseStoryRendererActivity loads a React Native component named "StoryRenderer", but it wasn't being registered. This caused the screenshot tests to fail with "StoryRenderer has not been registered". Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This helps diagnose why screenshots are blank by: - Adding console logs throughout the rendering process - Yellow background when loading (indicates stuck in async) - Red background when error (with error message) - Normal white when story renders Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Prevents false positives in Screenshotbot where screenshots differ only in EXIF/metadata (timestamps) but have identical pixel data. Uses Java ImageIO to re-write PNGs without metadata chunks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The pullDebugAndroidTestScreenshots task doesn't run in CI. The record task handles pulling internally, so hook into that instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The Gradle doLast approach didn't reliably strip metadata. Instead, split CI into three steps: record screenshots, strip EXIF with exiftool, then upload to Screenshotbot. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The EXIF metadata stripping was unnecessary — PNGs had no EXIF data. The real cause of Screenshotbot ACTION_REQUIRED is that main CI is failing (from PR #29), so Screenshotbot can't find a clean baseline. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code