tidy: remove dead StoryRenderer block from index.js#109
Open
EmilioBejasa wants to merge 1 commit into
Open
Conversation
The StoryRenderer registration was disabled because it broke Arnold's
Android Studio builds. The require('./.rnstorybook/storybook.requires')
call was still present and loading storybook on every bundle evaluation,
even though nothing used the result.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
I wouldn't call this a structural change. There's logic change happening in here, but I don't want this deleted yet. We still need this infrastructure eventually. I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the commented-out
StoryRendererregistration and therequire('./.rnstorybook/storybook.requires')call that loaded storybook on every bundle evaluation even though nothing used the result.The block was disabled because it broke Arnold's Android Studio builds. Since it was never coming back in this form, leaving the dead
requirecall was just noise.Pure structural change — no runtime behaviour changes.
🤖 Generated with Claude Code