-
Notifications
You must be signed in to change notification settings - Fork 1
constructViewTest: create ReactHostImpl directly (bridgeless) #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EmilioBejasa
wants to merge
8
commits into
main
Choose a base branch
from
bridgeless-isolated-construct-view-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2c80b92
constructViewTest: create ReactHostImpl directly for bridgeless isola…
EmilioBejasa 9f3ffe2
Fix blank screenshot in constructViewTest by using WindowManager overlay
EmilioBejasa 77c8864
Set white background on view before taking screenshot
EmilioBejasa d649d8c
Use WindowAttachment.dispatchAttach instead of WindowManager overlay
EmilioBejasa a05ae98
Take screenshot inside runOnMainSync to reduce non-determinism
EmilioBejasa 3dffa64
Put screenshot snap inside runOnMainSync and set explicit name
EmilioBejasa c0f1cca
Wait for React render before snapping screenshot
EmilioBejasa 52c0346
Fix blank screenshot by polling for Fabric view mounting
EmilioBejasa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
92 changes: 73 additions & 19 deletions
92
android/app/src/androidTest/java/com/testapp/IsolatedTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is also interesting. I wonder if the onHostResume depends on the Window being attached for it to do anything. Is there a reason this is before dispatchAttach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. We tested moving it after dispatchAttach — no behavioral difference. Looking at the source, onHostResume calls moveToOnHostResume(currentReactContext, activity) but currentReactContext is null at that point (surface hasn't started yet), so it's effectively a no-op either way. We've reordered it after dispatchAttach for correctness of intent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this something you copy pasted from Claude, or did you actually test this?
then why make the change? Adding extra code that does nothing makes it harder to figure out what's relevant and what's not. I don't care much for "correctness of intent"