This repository was archived by the owner on Aug 12, 2022. It is now read-only.
Draft
Conversation
Contributor
Author
|
Things that should be checked and done:
|
Merge dev into macOS support branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
Proposed Changes
CONTENTS_FOLDER_PATHtoUNLOCALIZED_RESOURCES_FOLDER_PATHinRun ScriptReason for Changes
[[NSBundle mainBundle] pathForResource], it will look for resource in theResourcesfolder, but we copied theHTML5resources to the/Contentsfolder. For macOS,$CONTENTS_FOLDER_PATHis$WRAPPER_NAME/Contentsand$UNLOCALIZED_RESOURCES_FOLDER_PATHis$CONTENTS_FOLDER_PATH/Contents/Resources, and$UNLOCALIZED_RESOURCES_FOLDER_PATHworks fine for both macOS and iOS. See Build Setting Reference from AppleTest Coverage