Changes in adapters in order to store parentID#942
Closed
Conversation
gzukowski
force-pushed
the
feat/parent-id
branch
2 times, most recently
from
2e1e91f to
65d3e6d
Compare
Contributor
alicja-gruzdz
left a comment
alicja-gruzdz
left a comment
There was a problem hiding this comment.
It looks like it's going in the right direction, thanks 🦾
Please see a couple of my comments.
gzukowski
force-pushed
the
feat/parent-id
branch
from
65d3e6d to
d007fde
Compare
agne6ka
suggested changes
Oct 11, 2023
Contributor
agne6ka
left a comment
agne6ka
left a comment
There was a problem hiding this comment.
Nice work so far 🙌
There is one extra info in response:
"container": {
"image": "scramjetorg/runner:0.35.2",
"maxMem": 512,
"exposePortsRange": [
30000,
32767
],
"hostIp": "0.0.0.0"
},
For more info see: https://github.com/scramjetorg/scramjet-cpm-dev/pull/608#pullrequestreview-1671284710
gzukowski
force-pushed
the
feat/parent-id
branch
from
d007fde to
ebb2d98
Compare
patuwwy
reviewed
Nov 13, 2023
| return { opStatus: ReasonPhrases.UNPROCESSABLE_ENTITY, error: "Invalid Instance id" }; | ||
| } | ||
| if (payload.instanceId) { | ||
| if (!IDProvider.isValid(payload.instanceId)) { |
Contributor
There was a problem hiding this comment.
will fail tests. actually we allow any 36chars long instance id and tests use not uuid 36 long strings
4 tasks
Contributor
|
Replaced with #985 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clickup Task:
https://app.clickup.com/t/24308805/VDM-1372