refactor!: remove header CLI and REPL support#24
Merged
andylokandy merged 1 commit intoscopedb:mainfrom Apr 27, 2026
Merged
Conversation
tisonkun
approved these changes
Apr 27, 2026
There was a problem hiding this comment.
Pull request overview
This PR removes the ability to set/manage custom HTTP headers via the CLI (--header) and via the REPL (/headers), consolidating header configuration to connection configuration (including env-based config overrides). It updates the internal client construction to accept extra headers at creation time instead of mutating them after.
Changes:
- Remove
--headerfrom CLI argument structs and eliminate runtime parsing/propagation of CLI headers. - Remove the REPL
/headerssubcommand and associated header-mutation plumbing. - Refactor
ScopeQLClient/Clientconstruction to carryextra_headersimmutably, and add coverage to verify extra headers are included in request headers.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scopeql/src/repl/entrypoint.rs | Drops /headers handling and removes headers parameter from REPL entrypoint. |
| scopeql/src/repl/command.rs | Removes the /headers subcommand definitions from the REPL command parser. |
| scopeql/src/main.rs | Removes CLI header parsing and stops passing headers into REPL/run/load code paths. |
| scopeql/src/load.rs | Removes HeaderMap parameter and relies on connection-config headers via ScopeQLClient::from_connection. |
| scopeql/src/execute.rs | Removes HeaderMap parameter and relies on connection-config headers via ScopeQLClient::from_connection. |
| scopeql/src/command.rs | Removes --header options from ReplArgs and ExecArgs. |
| scopeql/src/client/mod.rs | Removes mutable header APIs and passes parsed connection headers into Client::new(...). |
| scopeql/src/client/connection.rs | Extends Client::new(...) to accept extra headers; ensures request headers include them; updates/adds tests. |
| scopeql/src/header.rs | Updates doc comment to reflect broader usage of parse_headers. |
| CHANGELOG.md | Documents the breaking removal of CLI/REPL header management and points users to config/env-based headers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.