Skip to content

Removing langchain.js from testing suite due to yarn is necessary for installation#513

Merged
phracek merged 1 commit intosclorg:masterfrom
pacostas:remove-langchain
Jan 15, 2026
Merged

Removing langchain.js from testing suite due to yarn is necessary for installation#513
phracek merged 1 commit intosclorg:masterfrom
pacostas:remove-langchain

Conversation

@pacostas
Copy link
Copy Markdown
Contributor

@pacostas pacostas commented Nov 17, 2025 •
edited by github-actions Bot
Loading

Removing langchain.js from the testing suite.

This PR removes langchain.js from the testing suite because the yarn binary isn't available on the base images.

Until we further investigate how to properly include and install the yarn binary on the base images to test the langchain.js library, it's better to remove langchain.js. Currently, the failing test is a false alarm indication, as Langchain itself is not failing.

@phracek
Copy link
Copy Markdown
Member

phracek commented Nov 18, 2025

[test-upstream]

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 18, 2025 •
edited
Loading

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
Fedora - UpstreamTests - 22-minimalFedora-latestx86_64✅ passed15.01.2026 16:21:586min 47stest pipeline
Fedora - UpstreamTests - 24-minimalFedora-latestx86_64✅ passed15.01.2026 16:54:386min 31stest pipeline
Fedora - UpstreamTests - 20-minimalFedora-latestx86_64✅ passed15.01.2026 16:21:507min 48stest pipeline
CentOS Stream 10 - UpstreamTests - 22-minimalCentOS-Stream-10x86_64✅ passed15.01.2026 16:21:537min 51stest pipeline
CentOS Stream 10 - UpstreamTests - 24-minimalCentOS-Stream-10x86_64✅ passed15.01.2026 16:21:527min 29stest pipeline
RHEL8 - UpstreamTests - 20-minimalRHEL-8.10.0-Nightlyx86_64✅ passed15.01.2026 16:46:2927min 2stest pipeline
RHEL10 - UpstreamTests - 22-minimalRHEL-10-Nightlyx86_64✅ passed15.01.2026 16:21:5529min 9stest pipeline
RHEL9 - UpstreamTests - 22-minimalRHEL-9.6.0-Nightlyx86_64✅ passed15.01.2026 16:21:5232min 48stest pipeline
Fedora - UpstreamTests - 22Fedora-latestx86_64❌ error15.01.2026 16:21:5222min 41stest pipeline
RHEL9 - UpstreamTests - 20-minimalRHEL-9.6.0-Nightlyx86_64✅ passed15.01.2026 16:21:5034min 27stest pipeline
Fedora - UpstreamTests - 24Fedora-latestx86_64❌ error15.01.2026 16:21:5220min 40stest pipeline
RHEL10 - UpstreamTests - 24-minimalRHEL-10-Nightlyx86_64✅ passed15.01.2026 16:50:3229min 46stest pipeline
CentOS Stream 9 - UpstreamTests - 24CentOS-Stream-9x86_64❌ error15.01.2026 16:56:3623min 55stest pipeline
CentOS Stream 9 - UpstreamTests - 20CentOS-Stream-9x86_64❌ error15.01.2026 16:56:5223min 20stest pipeline
RHEL8 - UpstreamTests - 22-minimalRHEL-8.10.0-Nightlyx86_64✅ passed15.01.2026 16:21:5730min 24stest pipeline
CentOS Stream 10 - UpstreamTests - 24CentOS-Stream-10x86_64❌ error15.01.2026 16:21:5322min 7stest pipeline
CentOS Stream 9 - UpstreamTests - 24-minimalCentOS-Stream-9x86_64✅ passed15.01.2026 16:30:1610min 10stest pipeline
CentOS Stream 9 - UpstreamTests - 20-minimalCentOS-Stream-9x86_64✅ passed15.01.2026 16:21:589min 45stest pipeline
RHEL10 - UpstreamTests - 22RHEL-10-Nightlyx86_64❌ error15.01.2026 16:21:5147min 6stest pipeline
RHEL8 - UpstreamTests - 22RHEL-8.10.0-Nightlyx86_64❌ error15.01.2026 16:21:5049min 24stest pipeline
RHEL10 - UpstreamTests - 24RHEL-10-Nightlyx86_64❌ error15.01.2026 16:30:3943min 19stest pipeline
Fedora - UpstreamTests - 20Fedora-latestx86_64❌ error15.01.2026 16:21:5726min 13stest pipeline
RHEL8 - UpstreamTests - 20RHEL-8.10.0-Nightlyx86_64❌ error15.01.2026 16:52:2445min 16stest pipeline
RHEL9 - UpstreamTests - 24-minimalRHEL-9.6.0-Nightlyx86_64✅ passed18.11.2025 08:23:0617min 2stest pipeline
RHEL9 - UpstreamTests - 24RHEL-9.6.0-Nightlyx86_64❌ error15.01.2026 16:21:5753min 14stest pipeline
RHEL9 - UpstreamTests - 20RHEL-9.6.0-Nightlyx86_64❌ error15.01.2026 16:22:0348min 19stest pipeline
RHEL9 - UpstreamTests - 22RHEL-9.6.0-Nightlyx86_64❌ error15.01.2026 16:21:5253min 21stest pipeline
RHEL10 - FIPS Enabled - 24-minimalRHEL-10-Nightlyx86_64✅ passed15.01.2026 16:22:2533min 10stest pipeline
RHEL9 - FIPS Enabled - 20-minimalRHEL-9.6.0-Nightlyx86_64✅ passed15.01.2026 16:30:2238min 25stest pipeline
RHEL9 - FIPS Enabled - 24-minimalRHEL-9.6.0-Nightlyx86_64✅ passed15.01.2026 16:30:2639min 7stest pipeline
RHEL9 - FIPS Enabled - 24RHEL-9.6.0-Nightlyx86_64✅ passed15.01.2026 16:32:2139min 31stest pipeline
RHEL10 - FIPS Enabled - 22-minimalRHEL-10-Nightlyx86_64✅ passed15.01.2026 16:42:4131min 10stest pipeline
CentOS Stream 10 - UpstreamTests - 22CentOS-Stream-10x86_64❌ error15.01.2026 16:56:2420min 47stest pipeline
Fedora - 22-minimalFedora-latestx86_64✅ passed15.01.2026 17:11:028min 41stest pipeline
CentOS Stream 9 - 20CentOS-Stream-9x86_64✅ passed15.01.2026 17:10:5612min 1stest pipeline
CentOS Stream 10 - 22-minimalCentOS-Stream-10x86_64✅ passed15.01.2026 17:16:319min 39stest pipeline
RHEL10 - FIPS Enabled - 22RHEL-10-Nightlyx86_64✅ passed15.01.2026 16:44:2940min 59stest pipeline
RHEL9 - FIPS Enabled - 22RHEL-9.6.0-Nightlyx86_64✅ passed15.01.2026 16:46:4240min 27stest pipeline
RHEL10 - FIPS Enabled - 24RHEL-10-Nightlyx86_64✅ passed15.01.2026 16:58:4031min 23stest pipeline
Fedora - 20-minimalFedora-latestx86_64✅ passed15.01.2026 17:26:599min 16stest pipeline
CentOS Stream 10 - 22CentOS-Stream-10x86_64✅ passed15.01.2026 17:26:5011min 1stest pipeline
CentOS Stream 9 - 20-minimalCentOS-Stream-9x86_64✅ passed15.01.2026 17:29:1711min 53stest pipeline
RHEL10 - Unsubscribed host - 24RHEL-10-Nightlyx86_64✅ passed15.01.2026 17:12:2929min 2stest pipeline
RHEL10 - 22RHEL-10-Nightlyx86_64✅ passed15.01.2026 17:12:5630min 30stest pipeline
CentOS Stream 9 - 24CentOS-Stream-9x86_64✅ passed15.01.2026 17:31:1313min 40stest pipeline
RHEL9 - FIPS Enabled - 20RHEL-9.6.0-Nightlyx86_64✅ passed15.01.2026 17:03:2341min 59stest pipeline
RHEL9 - Unsubscribed host - 20-minimalRHEL-9.6.0-Nightlyx86_64✅ passed15.01.2026 17:15:0431min 49stest pipeline
RHEL9 - FIPS Enabled - 22-minimalRHEL-9.6.0-Nightlyx86_64✅ passed15.01.2026 17:10:3239min 10stest pipeline
RHEL9 - 20RHEL-9.6.0-Nightlyx86_64✅ passed15.01.2026 17:12:4636min 38stest pipeline
Fedora - 22Fedora-latestx86_64✅ passed15.01.2026 17:39:1710min 35stest pipeline
RHEL9 - 22RHEL-9.6.0-Nightlyx86_64✅ passed15.01.2026 17:16:4635min 41stest pipeline
CentOS Stream 10 - 24-minimalCentOS-Stream-10x86_64✅ passed15.01.2026 17:43:0411min 8stest pipeline
Fedora - 24Fedora-latestx86_64✅ passed15.01.2026 17:45:4710min 46stest pipeline
RHEL10 - 24-minimalRHEL-10-Nightlyx86_64✅ passed15.01.2026 17:21:1038min 1stest pipeline
RHEL10 - 22-minimalRHEL-10-Nightlyx86_64✅ passed15.01.2026 17:23:3036min 18stest pipeline
RHEL9 - 24-minimalRHEL-9.6.0-Nightlyx86_64✅ passed15.01.2026 17:15:0146min 26stest pipeline
RHEL8 - 20-minimalRHEL-8.10.0-Nightlyx86_64✅ passed15.01.2026 17:19:1142min 8stest pipeline
Fedora - 24-minimalFedora-latestx86_64✅ passed15.01.2026 17:53:218min 28stest pipeline
Fedora - 20Fedora-latestx86_64✅ passed15.01.2026 17:51:1610min 39stest pipeline
RHEL9 - Unsubscribed host - 22RHEL-9.6.0-Nightlyx86_64✅ passed15.01.2026 17:21:0343min 22stest pipeline
RHEL9 - Unsubscribed host - 24RHEL-9.6.0-Nightlyx86_64✅ passed15.01.2026 17:21:3043min 50stest pipeline
RHEL10 - Unsubscribed host - 22RHEL-10-Nightlyx86_64✅ passed15.01.2026 17:37:3031min 22stest pipeline
CentOS Stream 10 - 24CentOS-Stream-10x86_64✅ passed15.01.2026 17:55:3912min 32stest pipeline
RHEL10 - 24RHEL-10-Nightlyx86_64✅ passed15.01.2026 17:39:0031min 19stest pipeline
CentOS Stream 9 - 24-minimalCentOS-Stream-9x86_64✅ passed15.01.2026 17:59:4412min 37stest pipeline
RHEL9 - 20-minimalRHEL-9.6.0-Nightlyx86_64✅ passed15.01.2026 17:41:4433min 13stest pipeline
RHEL10 - Unsubscribed host - 24-minimalRHEL-10-Nightlyx86_64✅ passed15.01.2026 17:47:3330min 20stest pipeline
RHEL10 - Unsubscribed host - 22-minimalRHEL-10-Nightlyx86_64✅ passed15.01.2026 17:51:4227min 16stest pipeline
RHEL9 - Unsubscribed host - 22-minimalRHEL-9.6.0-Nightlyx86_64✅ passed15.01.2026 17:45:3033min 29stest pipeline
RHEL9 - Unsubscribed host - 24-minimalRHEL-9.6.0-Nightlyx86_64✅ passed15.01.2026 17:51:0631min 35stest pipeline
RHEL9 - Unsubscribed host - 20RHEL-9.6.0-Nightlyx86_64✅ passed15.01.2026 17:45:4638min 27stest pipeline
RHEL8 - 22-minimalRHEL-8.10.0-Nightlyx86_64✅ passed15.01.2026 17:58:1230min 4stest pipeline
RHEL9 - 22-minimalRHEL-9.6.0-Nightlyx86_64✅ passed15.01.2026 17:53:1936min 18stest pipeline
RHEL8 - 22RHEL-8.10.0-Nightlyx86_64✅ passed15.01.2026 18:02:1730min 44stest pipeline

@phracek
Copy link
Copy Markdown
Member

phracek commented Nov 19, 2025

Test failed for this reason for Version 20:

 [FAILED] for 'clients' test_client_fastify (00:05:43)
 [FAILED] for 'clients' test_client_pino (00:05:21)

for test_client_fastify:

> fastify@5.6.2 test
> npm run lint && npm run unit && npm run test:typescript


> fastify@5.6.2 lint
> npm run lint:eslint


> fastify@5.6.2 lint:eslint
> eslint


> fastify@5.6.2 unit
> borp

parsed config: test/**/*.test.js test/**/*.test.mjs
✔ should resolve immediately when reply[kReplyHijacked] is true (1.468486ms)
✖ should reject immediately when reply[kReplyHijacked] is true (0.511853ms)
  TypeError [Error]: t.plan is not a function
      at TestContext.<anonymous> (/opt/app-root/src/test/wrap-thenable.test.js:19:5)
      at Test.runInAsyncScope (node:async_hooks:206:9)
      at Test.run (node:internal/test_runner/test:631:25)
      at Test.processPendingSubtests (node:internal/test_runner/test:374:18)
      at Test.postRun (node:internal/test_runner/test:715:19)
      at Test.run (node:internal/test_runner/test:673:12)
      at async startSubtest (node:internal/test_runner/harness:216:3)

for pino

✔ destination (105.055102ms)
ℹ tests 516
ℹ suites 9
ℹ pass 514
ℹ fail 0
ℹ cancelled 2
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 193520.078485

✖ failing tests:

test at test/multistream.test.js:1:1
✖ /opt/app-root/src/test/multistream.test.js (60003.856481ms)
  'test timed out after 60000ms'

test at test/basic.test.js:1:1
✖ /opt/app-root/src/test/basic.test.js (60007.371521ms)
  'test timed out after 60000ms'
----------------------|---------|----------|---------|---------|------------------------------------
File                  | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                  
----------------------|---------|----------|---------|---------|------------------------------------
All files             |   97.44 |    97.09 |   98.44 |   97.44 |                                    
 src                  |   97.47 |     97.1 |   95.23 |   97.47 |                                    
  browser.js          |   96.23 |    96.93 |   94.59 |   96.23 | 124-125,367-368,375-378,490-500    
  file.js             |     100 |      100 |     100 |     100 |                                    
  pino.js             |     100 |    97.56 |     100 |     100 | 163                                
 src/lib              |   97.42 |    97.08 |     100 |   97.42 |                                    
  caller.js           |   86.66 |    66.66 |     100 |   86.66 | 14-15,23-24                        
  constants.js        |     100 |      100 |     100 |     100 |                                    
  levels.js           |   99.17 |    98.76 |     100 |   99.17 | 225-226                            
  meta.js             |     100 |      100 |     100 |     100 |                                    
  multistream.js      |   99.01 |    98.38 |     100 |   99.01 | 102-103                            
  proto.js            |   99.21 |    97.36 |     100 |   99.21 | 248-249                            
  redaction.js        |     100 |      100 |     100 |     100 |                                    
  symbols.js          |     100 |      100 |     100 |     100 |                                    
  time.js             |     100 |      100 |     100 |     100 |                                    
  tools.js            |   97.16 |    97.43 |     100 |   97.16 | ...122,275,302-303,306-310,343-344 
  transport-stream.js |   66.07 |    81.81 |     100 |   66.07 | 19-26,35-45                        
  transport.js        |    98.2 |       98 |     100 |    98.2 | 47-48,66                           
  worker.js           |   98.45 |     93.1 |     100 |   98.45 | 185-187                            
----------------------|---------|----------|---------|---------|------------------------------------
Test for image 'fedora/nodejs-20:20' FAILED (exit code: 1)
Test for image 'fedora/nodejs-20:20' FAILED (exit code: 1)

@phracek
Copy link
Copy Markdown
Member

phracek commented Nov 19, 2025

@pacostas Please address issues in this Pull request as well.

@pacostas
Copy link
Copy Markdown
Contributor Author

pacostas commented Nov 19, 2025

@phracek I'm not able to reproduce that locally by using the following commands

cd ./s2i-nodejs-container
make build TARGET=rhel8 VERSIONS=20 BUILD_OPTIONS="-t rhel8_20_builder"
s2i build https://github.com/pinojs/pino.git rhel8_20_builder rhel8_20_pino -e NODE_ENV="development"
docker run -e INIT_WRAPPER=false -e NODE_CMD="npm run test" rhel8_20_pino

Do you know if that is the closest environment that someone can have locally for testing the node modules?

@pacostas
Copy link
Copy Markdown
Contributor Author

pacostas commented Nov 27, 2025

@phracek This issues are not related to the PR changes. Also fastify and pino do not fail on the nodejs upstream nightly builds. Can you please re-trigger the tests?

@phracek
Copy link
Copy Markdown
Member

phracek commented Jan 13, 2026

@pacostas Please rebase it agains master. And we can merge it.

@phracek
Copy link
Copy Markdown
Member

phracek commented Jan 15, 2026

[test][test-upstream]

@phracek
Copy link
Copy Markdown
Member

phracek commented Jan 15, 2026

In the most cases 'fastify' and 'pino' are failing.

@phracek phracek merged commit 9d3e0ba into sclorg:master Jan 15, 2026
50 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pacostas @phracek