Change domain names to standard scheme #121
Conversation
docs/odin/odin-data-reduction.ipynb
Outdated
| "outputs": [], | ||
| "source": [ | ||
| "masked = wf.compute(CountsMasked[SampleRun])\n", | ||
| "masked = wf.compute(MaskedDetector[SampleRun])\n", |
There was a problem hiding this comment.
Shouldn't this be CorrectedDetector instead of MaskedDetector?
| MonitorType = TypeVar( | ||
| "MonitorType", BeamMonitor1, BeamMonitor2, BeamMonitor3, BeamMonitor4 | ||
| ) | ||
| RunType = reduce_t.RunType |
There was a problem hiding this comment.
We would like to keep the imaging runtypes here, as the names fit better than the ones in essreduce.
There was a problem hiding this comment.
What do you mean? The names haven't changed. The only difference is that the type var is no longer constrained. This has do be done when constructing a pipeline.
Mixing type vars is tricky. If they happen to get different constraints (ess.reduce.nexus.types.RunType via Pipeline(constraints=...) and ess.imaging.types.RunType via TypeVar contraints), then the pipeline will fail to build with obscure errors. I changed this definition precisely because I encountered such an error.
There was a problem hiding this comment.
Ok, I misunderstood, I thought we now had to use the names from essreduce.
Then it's fine 👍
No description provided.