Skip to content

fix: don't raise in case we encounter modules we don't know#63

Merged
MridulS merged 2 commits into
mainfrom
fix-add-modules
Aug 4, 2025
Merged

fix: don't raise in case we encounter modules we don't know#63
MridulS merged 2 commits into
mainfrom
fix-add-modules

Conversation

@jokasimr
Copy link
Copy Markdown
Contributor

Fixes #62

@jokasimr jokasimr requested a review from SimonHeybrock July 11, 2025 08:12
@jokasimr
Copy link
Copy Markdown
Contributor Author

Should we just accept any module values instead of checking that they belong to the list?
Then we don't have to change this when a new flatbuffer schema is added.

@SimonHeybrock
Copy link
Copy Markdown
Member

SimonHeybrock commented Jul 11, 2025

Should we just accept any module values instead of checking that they belong to the list? Then we don't have to change this when a new flatbuffer schema is added.

Yes, makes sense! Should we include the number of skipped modules per category in the final report? Or just print a message?

@jokasimr
Copy link
Copy Markdown
Contributor Author

I'm thinking we don't show anything about the ignored modules, module is not part of the nexus standard anyway so it makes sense that we don't check them, it should not be expected that we do. If we know how to check those entries anyway that is of course useful, but it's just a bonus.

@jokasimr jokasimr removed the request for review from SimonHeybrock July 14, 2025 08:34
@github-project-automation github-project-automation Bot moved this to In progress in Development Board Jul 14, 2025
@jokasimr jokasimr moved this from In progress to Selected in Development Board Jul 14, 2025
@jokasimr jokasimr changed the title fix: add more unused modules fix: don't raise in case we encounter modules we don't know Jul 14, 2025
@MridulS MridulS merged commit 705806f into main Aug 4, 2025
4 checks passed
@MridulS MridulS deleted the fix-add-modules branch August 4, 2025 10:40
@github-project-automation github-project-automation Bot moved this from Selected to Done in Development Board Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

JSON handle da00

3 participants