Fix sam_knn.py variable name for reset#281
Open
ginop wants to merge 2 commits intoscikit-multiflow:masterfrom
Open
Fix sam_knn.py variable name for reset#281ginop wants to merge 2 commits intoscikit-multiflow:masterfrom
ginop wants to merge 2 commits intoscikit-multiflow:masterfrom
Conversation
As presented here, scikit-multiflow#272, `SAMKNNClassifier` cannot use the `reset()` method. This seems to be due to the name mismatch between internal variable `self.max_wind_size` and input argument `max_window_size`. `max_wind_size` does not appear to be referenced anywhere else in the library, so simply editing the name to match `max_window_size` in `SAMKNNClassifier.__init__()` may be all the change that is needed to fix this.
…ue (previously 'None')
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
=======================================
Coverage 88.20% 88.20%
=======================================
Files 156 156
Lines 13013 13013
=======================================
Hits 11478 11478
Misses 1535 1535
|
Author
|
No checks were failed, but two were canceled. As far as I can tell, this was not caused by the PR and the edited code does not need further changes. What should I do to resolve this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As presented here, #272,
SAMKNNClassifiercannot use thereset()method. This seems to be due to the name mismatch between internal variableself.max_wind_sizeand input argumentmax_window_size.max_wind_sizedoes not appear to be referenced anywhere else in the library, so simply editing the name to matchmax_window_sizeinSAMKNNClassifier.__init__()may be all the change that is needed to fix this.Changes proposed in this pull request:
max_wind_sizetomax_window_sizeon all three uses inSAMKNNClassifier.__init__().expected_infointest_sam_knn_coverageto reflect corrected value formax_window_sizeChecklist
Implementation
Tests