fix: declare editable.mode for hello-cmake-package#66
Open
henryiii wants to merge 1 commit into
Open
Conversation
The upcoming scikit-build release, backed by scikit-build-core's setuptools plugin, requires editable.mode = "inplace" under [tool.scikit-build] for editable installs. Assisted-by: ClaudeCode:claude-fable-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fun fact: this was generated by Claude Fable 5 - while working on a different PR: scikit-build/scikit-build#1185.
🤖 AI text below 🤖
The next major scikit-build release replaces its backend with scikit-build-core's setuptools plugin (see scikit-build/scikit-build-core#1316; scikit-build draft PR to follow). Editable/inplace installs there require
editable.mode = "inplace"under[tool.scikit-build], so this adds that to hello-cmake-package's pyproject.toml.No other changes needed: all six classic-skbuild sample projects (hello-cpp, hello-pure, hello-cython, hello-pybind11, pen2-cython, hello-cmake-package) build unchanged against the new backend, and scikit-build's CI now builds them on Linux/macOS/Windows as a regression check.
🤖 Generated with Claude Code