Open
Conversation
45d04fd to
04d9881
Compare
This comment was marked as resolved.
This comment was marked as resolved.
81f9407 to
9cc8ea9
Compare
bf6146a to
890ee81
Compare
890ee81 to
fc253ec
Compare
Closed
fc253ec to
ccaf24e
Compare
|
Thanks for this PR. Should it already be working? I tried commits 9700ce0 and b4652c5 and got the following error (with b4652c5): I set up my pjproject.toml as: |
Collaborator
Author
It used to work, but I think I did a hasty refactor and broke it. I'll try to get it back to working state this week. There were some unresolved failures, but I don't think there were on the linux builders. There is an issue with patchelf on Fedora distros (and probably many other), but I had a version using |
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
893377e to
928e504
Compare
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
`auditwheel` pacher forces `DT_RPATH`. Here instead we use `DT_RUNPATH` so that it can be overwritten by the user Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
This is needed because the last delocate package that supports python 3.8 does not have _get_rpaths Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
928e504 to
ce63083
Compare
Collaborator
Author
|
@FabianSchuetze Could you try again with this branch and/or https://github.com/LecrisUT/scikit-build-core/tree/feat/lief ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this is:
sysconfig.get_path("platlib")(pip fake venv is really annoying here)
CMAKE_INSTALL_RPATH_USE_LINK_PATHScriptspath.Maybe would be better to use the existing paths instead.
Do some other magic thatdelvewheeldoesAfaict, the only special thing it does is inject
os.add_dll_directory. Cannot supportsubprocess.runright now, but we could do it if we generate the wrappers. Will make a subsequent PR for that.To discuss:
scikit-build.repair-wheel?auditwheel/delocate/delvewheeldirectly, but these do not handle differently the packages in site-package vs externaldlevewheelwhich creates separate dlls for each wheel.Depends-on: #1022 #1016