remove stream_in and stream_out nodes #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nice! I can take a look at this today, I am cleaning up some of the other things. |
gilbert-sci
suggested changes
Aug 8, 2025
Contributor
gilbert-sci
left a comment
gilbert-sci
left a comment
There was a problem hiding this comment.
Some other spots I found that we should remove:
- We should update the README to remove mention of StreamIn or StreamOut (and probably run and replace the output of synapsectl --help in the readme with the latest output
- I just landed the synapse-api changes, so we can update the submodule to main
- we can probably go ahead and delete synapse/tests/blink_ostim.py
- we can also probably go ahead and delete synapse/tests/doom_synapse.py
Thank you for the contributions! Let me know if you have any questions.
Contributor
Author
|
Thanks for the review. I have pushed the changes. |
gilbert-sci
suggested changes
Aug 11, 2025
Contributor
gilbert-sci
left a comment
gilbert-sci
left a comment
There was a problem hiding this comment.
Getting there, I found some stragglers:
In synapse/server/rpc.py:330
if node.type in [NodeType.kStreamIn, NodeType.kBroadbandSource]:
node.configure_iface_ip(self.iface_ip)
Contributor
Author
|
my bad. fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following sciencecorp/synapse-api#69