Change filter corner name fields. #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmazhou
reviewed
Mar 25, 2025
Contributor
emmazhou
left a comment
emmazhou
left a comment
There was a problem hiding this comment.
should we just call them both low_pass_hz and high_pass_hz?
Contributor
Author
|
:P i did not mean to have them named different. I do kind of want to keep "corner" or "cutoff" in there because I feel like just calling it "low_pass_hz" is a little ambiguous but I dont have strong feelings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users have mentioned a few times now that "low cutoff" and "high cutoff" are confusing. Most people with EE or signal processing experience expect filters to be referred to by their pass band, not their stop band. This changes field names but does not change their functionality.
I marked the previous tag numbers as reserved but I am not sure if this is strictly necessary since they are just being renamed.