Sourcery Starbot ⭐ refactored schorrm/pybaseball #19

SourceryAI · 2021-02-17T10:02:19Z

Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨

Here's your pull request refactoring your most popular Python repo.

If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch https://github.com/sourcery-ai-bot/pybaseball master
git merge --ff-only FETCH_HEAD
git reset HEAD^

SourceryAI · 2021-02-17T10:02:20Z

pybaseball/amateur_draft.py

-    res = requests.get(url, timeout=None).content 
-    draft_results = pd.read_html(res)
-    return draft_results
+    res = requests.get(url, timeout=None).content
+    return pd.read_html(res)


Function get_draft_results refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2021-02-17T10:02:21Z

pybaseball/batting_leaders.py

    soup = get_soup(start_season=start_season, end_season=end_season, league=league, qual=qual, ind=ind)
-    table = get_table(soup, ind)
-    return table
+    return get_table(soup, ind)


Function batting_stats refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2021-02-17T10:02:21Z

pybaseball/lahman.py

-	# do this for every table in the lahman db so they can exist as separate functions
-	z = get_lahman_zip()
-	f = os.path.join(base_string, "Parks.csv")
-	data = pd.read_csv(f if z is None else z.open(f), header=0, sep=',', quotechar="'")
-	return data
+    # do this for every table in the lahman db so they can exist as separate functions
+    z = get_lahman_zip()
+    f = os.path.join(base_string, "Parks.csv")
+    return pd.read_csv(
+        f if z is None else z.open(f), header=0, sep=',', quotechar="'"
+    )


Function parks refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2021-02-17T10:02:21Z

pybaseball/lahman.py

-	z = get_lahman_zip()
-	f = os.path.join(base_string, "AllstarFull.csv")
-	data = pd.read_csv(f if z is None else z.open(f), header=0, sep=',', quotechar="'")
-	return data
+    z = get_lahman_zip()
+    f = os.path.join(base_string, "AllstarFull.csv")
+    return pd.read_csv(
+        f if z is None else z.open(f), header=0, sep=',', quotechar="'"
+    )


Function all_star_full refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2021-02-17T10:02:21Z

pybaseball/lahman.py

-	z = get_lahman_zip()
-	f = os.path.join(base_string, "Appearances.csv")
-	data = pd.read_csv(f if z is None else z.open(f), header=0, sep=',', quotechar="'")
-	return data
+    z = get_lahman_zip()
+    f = os.path.join(base_string, "Appearances.csv")
+    return pd.read_csv(
+        f if z is None else z.open(f), header=0, sep=',', quotechar="'"
+    )


Function appearances refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2021-02-17T10:02:22Z

pybaseball/lahman.py

-	z = get_lahman_zip()
-	f = os.path.join(base_string, "FieldingPost.csv")
-	data = pd.read_csv(f if z is None else z.open(f), header=0, sep=',', quotechar="'")
-	return data
+    z = get_lahman_zip()
+    f = os.path.join(base_string, "FieldingPost.csv")
+    return pd.read_csv(
+        f if z is None else z.open(f), header=0, sep=',', quotechar="'"
+    )


Function fielding_post refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2021-02-17T10:02:22Z

pybaseball/lahman.py

-	z = get_lahman_zip()
-	f = os.path.join(base_string, "HallOfFame.csv")
-	data = pd.read_csv(f if z is None else z.open(f), header=0, sep=',', quotechar="'")
-	return data
+    z = get_lahman_zip()
+    f = os.path.join(base_string, "HallOfFame.csv")
+    return pd.read_csv(
+        f if z is None else z.open(f), header=0, sep=',', quotechar="'"
+    )


Function hall_of_fame refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2021-02-17T10:02:22Z

pybaseball/lahman.py

-	z = get_lahman_zip()
-	f = os.path.join(base_string, "HomeGames.csv")
-	data = pd.read_csv(f if z is None else z.open(f), header=0, sep=',', quotechar="'")
-	return data
+    z = get_lahman_zip()
+    f = os.path.join(base_string, "HomeGames.csv")
+    return pd.read_csv(
+        f if z is None else z.open(f), header=0, sep=',', quotechar="'"
+    )


Function home_games refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2021-02-17T10:02:23Z

pybaseball/lahman.py

-	z = get_lahman_zip()
-	f = os.path.join(base_string, "Managers.csv")
-	data = pd.read_csv(f if z is None else z.open(f), header=0, sep=',', quotechar="'")
-	return data
+    z = get_lahman_zip()
+    f = os.path.join(base_string, "Managers.csv")
+    return pd.read_csv(
+        f if z is None else z.open(f), header=0, sep=',', quotechar="'"
+    )


Function managers refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2021-02-17T10:02:23Z

pybaseball/lahman.py

-	z = get_lahman_zip()
-	f = os.path.join(base_string, "ManagersHalf.csv")
-	data = pd.read_csv(f if z is None else z.open(f), header=0, sep=',', quotechar="'")
-	return data
+    z = get_lahman_zip()
+    f = os.path.join(base_string, "ManagersHalf.csv")
+    return pd.read_csv(
+        f if z is None else z.open(f), header=0, sep=',', quotechar="'"
+    )


Function managers_half refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2021-02-17T10:02:24Z

pybaseball/lahman.py

-	z = get_lahman_zip()
-	f = os.path.join(base_string, "People.csv")
-	data = pd.read_csv(f if z is None else z.open(f), header=0, sep=',', quotechar="'")
-	return data
+    z = get_lahman_zip()
+    f = os.path.join(base_string, "People.csv")
+    return pd.read_csv(
+        f if z is None else z.open(f), header=0, sep=',', quotechar="'"
+    )


Function people refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2021-02-17T10:02:25Z

pybaseball/lahman.py

-	z = get_lahman_zip()
-	f = os.path.join(base_string, "Pitching.csv")
-	data = pd.read_csv(f if z is None else z.open(f), header=0, sep=',', quotechar="'")
-	return data
+    z = get_lahman_zip()
+    f = os.path.join(base_string, "Pitching.csv")
+    return pd.read_csv(
+        f if z is None else z.open(f), header=0, sep=',', quotechar="'"
+    )


Function pitching refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2021-02-17T10:02:25Z

pybaseball/lahman.py

-	z = get_lahman_zip()
-	f = os.path.join(base_string, "PitchingPost.csv")
-	data = pd.read_csv(f if z is None else z.open(f), header=0, sep=',', quotechar="'")
-	return data
+    z = get_lahman_zip()
+    f = os.path.join(base_string, "PitchingPost.csv")
+    return pd.read_csv(
+        f if z is None else z.open(f), header=0, sep=',', quotechar="'"
+    )


Function pitching_post refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2021-02-17T10:02:25Z

pybaseball/lahman.py

-	z = get_lahman_zip()
-	f = os.path.join(base_string, "Salaries.csv")
-	data = pd.read_csv(f if z is None else z.open(f), header=0, sep=',', quotechar="'")
-	return data
+    z = get_lahman_zip()
+    f = os.path.join(base_string, "Salaries.csv")
+    return pd.read_csv(
+        f if z is None else z.open(f), header=0, sep=',', quotechar="'"
+    )


Function salaries refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2021-02-17T10:02:25Z

pybaseball/lahman.py

-	z = get_lahman_zip()
-	f = os.path.join(base_string, "SeriesPost.csv")
-	data = pd.read_csv(f if z is None else z.open(f), header=0, sep=',', quotechar="'")
-	return data 
+    z = get_lahman_zip()
+    f = os.path.join(base_string, "SeriesPost.csv")
+    return pd.read_csv(
+        f if z is None else z.open(f), header=0, sep=',', quotechar="'"
+    ) 


Function series_post refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2021-02-17T10:02:27Z

pybaseball/standings.py

 def get_tables(soup, season):
    datasets = []
-    if(season>=1969):
+    if (season>=1969):


Function get_tables refactored with the following changes:

Replace unused for index with underscore (for-index-underscore)

SourceryAI · 2021-02-17T10:02:27Z

pybaseball/standings.py

-        elif season<=1904: code = BeautifulSoup(t[15], "lxml")
+        else:
+            code = BeautifulSoup(t[15], "lxml")


Function standings refactored with the following changes:

Remove redundant conditional (remove-redundant-if)

SourceryAI · 2021-02-17T10:02:27Z

pybaseball/statcast.py

-    # 3 days or less -> a quick one-shot request. Greater than 3 days -> break it into multiple smaller queries
-    small_query_threshold = 5


Function statcast refactored with the following changes:

Move assignments closer to their usage (move-assign)

SourceryAI · 2021-02-17T10:02:27Z

pybaseball/statcast_batter.py

        url = 'https://baseballsavant.mlb.com/statcast_search/csv?all=true&hfPT=&hfAB=&hfBBT=&hfPR=&hfZ=&stadium=&hfBBL=&hfNewZones=&hfGT=R%7CPO%7CS%7C=&hfSea=&hfSit=&player_type=batter&hfOuts=&opponent=&pitcher_throws=&batter_stands=&hfSA=&game_date_gt={}&game_date_lt={}&batters_lookup%5B%5D={}&team=&position=&hfRO=&home_road=&hfFlag=&metric_1=&hfInn=&min_pitches=0&min_results=0&group_by=name&sort_col=pitches&player_event_sort=h_launch_speed&sort_order=desc&min_abs=0&type=details&'
-        df = split_request(start_dt, end_dt, player_id, url)
-        return df
+        return split_request(start_dt, end_dt, player_id, url)


Function statcast_batter refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2021-02-17T10:02:27Z

pybaseball/statcast_batter.py

-    data = pd.read_csv(io.StringIO(res.decode('utf-8')))
-    return data
+    return pd.read_csv(io.StringIO(res.decode('utf-8')))


Function statcast_batter_exitvelo_barrels refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2021-02-17T10:02:29Z

pybaseball/statcast_pitcher.py

        url = 'https://baseballsavant.mlb.com/statcast_search/csv?all=true&hfPT=&hfAB=&hfBBT=&hfPR=&hfZ=&stadium=&hfBBL=&hfNewZones=&hfGT=R%7CPO%7CS%7C=&hfSea=&hfSit=&player_type=pitcher&hfOuts=&opponent=&pitcher_throws=&batter_stands=&hfSA=&game_date_gt={}&game_date_lt={}&pitchers_lookup%5B%5D={}&team=&position=&hfRO=&home_road=&hfFlag=&metric_1=&hfInn=&min_pitches=0&min_results=0&group_by=name&sort_col=pitches&player_event_sort=h_launch_speed&sort_order=desc&min_abs=0&type=details&'
-        df = split_request(start_dt, end_dt, player_id, url)
-        return df
+        return split_request(start_dt, end_dt, player_id, url)


Function statcast_pitcher refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2021-02-17T10:02:30Z

pybaseball/team_batting.py

-        else:
-            pass
-


Function postprocessing refactored with the following changes:

Remove redundant pass statement (remove-redundant-pass)

SourceryAI · 2021-02-17T10:02:30Z

pybaseball/team_game_logs.py

        raise RuntimeError("Table with expected id not found on scraped page.")
-    data = pd.read_html(str(table))[0]
-    return data
+    return pd.read_html(str(table))[0]


Function get_table refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2021-02-17T10:02:30Z

pybaseball/top_prospects.py

-    teamUrl = "" if teamName == None else teamName.lower() + '/'
+    teamUrl = "" if teamName is None else teamName.lower() + '/'
    url = f"https://www.mlb.com/{teamUrl}prospects/stats/top-prospects"
    res = requests.get(url, timeout=None).content
    prospectList = pd.read_html(res)
    if playerType == "batters":
-        topBattingProspects = postprocess(prospectList[0])
-        return topBattingProspects
+        return postprocess(prospectList[0])
    elif playerType == "pitchers":
-        topPitchingProspects = postprocess(prospectList[1])
-        return topPitchingProspects
-    elif playerType == None: 
+        return postprocess(prospectList[1])
+    elif playerType is None: 


Function top_prospects refactored with the following changes:

Use x is None rather than x == None (none-compare)

Inline variable that is immediately returned (inline-immediately-returned-variable)

'Refactored by Sourcery'

a31fd15

SourceryAI commented Feb 17, 2021

View reviewed changes

		# 3 days or less -> a quick one-shot request. Greater than 3 days -> break it into multiple smaller queries
		small_query_threshold = 5

Sourcery Starbot ⭐ refactored schorrm/pybaseball #19

Are you sure you want to change the base?

Sourcery Starbot ⭐ refactored schorrm/pybaseball #19

Uh oh!

Conversation

SourceryAI commented Feb 17, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant