feat: add UPnP support for automatic port forwarding in the TCP server. #656 #1012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goyal-aman
changed the title
Owner
|
Please just test by trying to send using the upnp sending |
Author
|
@schollz this pr adds functionality to add port-mappings in router (and clears them) for router to listen on. test using the upnp sending? I dont understand. am I missing something? |
Author
|
@schollz gentle reminder ^ I've tested it btw it ads port mappings to router and removes them. |
Owner
|
Did you test what happens if the router already uses a port? Does it collide? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#656
Description: add port mapping in router (port forwarding) for router to listen on.
@schollz Here is the first draft. How do I test it though?