fix multi-track MIDI parsing when meta events have delta time 0 #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The condition `if (deltatime || evt->type)` skipped storing messages when both deltatime and type were 0. This caused meta events at the start of tracks (key signature, time signature, track name, etc.) to be dropped, corrupting the delta time chain for subsequent notes. This resulted in most notes being missed during playback for affected MIDI files. For example, https://frank-buss.de/tmp/bwv-846.mid has 548 note-on events but only 85 were being played. timidity plays this file correctly. The fix removes the conditional and always stores parsed messages to preserve timing integrity."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition
if (deltatime || evt->type)skipped storing messages when both deltatime and type were 0. This caused meta events at the start of tracks (key signature, time signature, track name, etc.) to be dropped, corrupting the delta time chain for subsequent notes.This resulted in most notes being missed during playback for affected MIDI files. For example, https://frank-buss.de/tmp/bwv-846.mid has 548 note-on events but only 85 were being played. timidity plays this file correctly.
The fix removes the conditional and always stores parsed messages to preserve timing integrity.