Skip to content

tests: make the tcpserver test big-endian clean #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
obbardc wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

tests: make the tcpserver test big-endian clean #287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions testing/int/tcpserver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#include <asio/read_until.hpp>
#include <asio/write.hpp>
#include <catch2/catch_all.hpp>
#include <algorithm>
#include <functional>
#include <sstream>
#include <thread>
Expand Down Expand Up @@ -94,7 +95,11 @@ auto with_read_callback(const char *name, std::function<void(const std::string &
void check_streamfeed_100_response(const std::string &res) {
REQUIRE(res.substr(0, 4) == "\x7f\x01\x09\2");
INFO(bytes_to_hexstr(res.substr(0, 10)));
auto info_len = *reinterpret_cast<const uint16_t*>(res.data() + 4);
// The portable binary archive serializes integers little-endian on the wire, so decode
// the 2-byte info-length prefix explicitly instead of via a host-order load (which would
// read it byte-swapped on big-endian hosts).
const auto *lenp = reinterpret_cast<const unsigned char *>(res.data() + 4);
uint16_t info_len = static_cast<uint16_t>(lenp[0] | (lenp[1] << 8));

REQUIRE(static_cast<int>(res.size()) > 6 + info_len);

Expand Down Expand Up @@ -134,8 +139,13 @@ TEST_CASE("tcpserver", "[network]") {
auto endofheader = res.find("\r\n\r\n");
REQUIRE(endofheader != std::string::npos);
std::string received_pattern = res.substr(endofheader + 4);
std::string expected = "\2" TESTPAT_TIMESTAMP TESTPAT_STR;
expected += expected;
// String streams carry zero-size values, so the server applies no endian
// conversion and emits the timestamp double in host byte order. TESTPAT_TIMESTAMP
// is the little-endian encoding; byte-reverse it on big-endian hosts.
std::string ts = TESTPAT_TIMESTAMP;
if (lsl::LSL_BYTE_ORDER == lsl::LSL_BIG_ENDIAN) std::reverse(ts.begin(), ts.end());
std::string sample = "\2" + ts + std::string(TESTPAT_STR, sizeof(TESTPAT_STR) - 1);
std::string expected = sample + sample;
cmp_binstr(expected, received_pattern);
}));

Expand Down
Loading